This is the mail archive of the sid@sources.redhat.com mailing list for the SID project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] ELF loader

From: Dave Brolley <brolley at redhat dot com>
To: Ben Elliston <bje at wasabisystems dot com>
Cc: sid at sources dot redhat dot com
Date: Fri, 13 Feb 2004 10:17:25 -0500
Subject: Re: [patch] ELF loader
References: <402BE20E.2030804@redhat.com> <87r7wz65fw.fsf@wasabisystems.com>

Ben Elliston wrote:

Dave Brolley <brolley@redhat.com> writes:

I'm committing the attached patch which requirks the ELF loader to correct the following problems:

This looks mostly fine, however I have one question: where is the dependency on libiberty introduced and can it be avoided?

I used xrealloc to allocate loadAreas and textSections. It used to be an unchecked hard coded limit of 100 elements each. I figured that using libiberty was ok since it's already used by sid/component/cgen-cpu. That's where I got the Makefile.am changes.

It could be avoided by using realloc and checking for failure. I guess failure would have to result in an abort?

Dave

Follow-Ups:
- Re: [patch] ELF loader
  - From: Frank Ch. Eigler

References:
- [patch] ELF loader
  - From: Dave Brolley
- Re: [patch] ELF loader
  - From: Ben Elliston

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]