Re: CPU disassembler-memory accessor

["Frank Ch. Eigler" <fche at redhat dot com>]

Hi -

bje wrote:
> [...]
> The following patch adds a third accessor to CPUs for the purpose of
> providing the disassembler with access to the instruction memory
> without causing undesirable side effects in the memory hierarchy.
> [...]

Thanks.

> [...] Any comments?

Yes, just one.  The read_disasm_memory_1 function is methinks
overengineered.  It doesn't need to throw exceptions, nor handle
accesses of other sizes.  Actually, why not just do a direct
sid::bus-level read() on the accessor and do away with the
read_disasm_memory* thingie altogether?


- FChE

Attachment: msg00024/pgp00000.pgp
Description: PGP signature