This is the mail archive of the sid@sources.redhat.com mailing list for the SID project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Warning fix for loader component


Matt,

I noticed a warning coming from g++ when building the loader component
library and, after doing some research, have concluded that the
obvious change is the right one.

Why was dest_addr cast to void *?  It seems to me this way leads to
lossage!  (On my system, the sizeof (void *) is 4).

Okay to commit?

Ben

Index: compLoader.cxx
===================================================================
RCS file: /cvs/cvsfiles/devo/sid/component/loader/compLoader.cxx,v
retrieving revision 1.37
diff -u -r1.37 compLoader.cxx
--- compLoader.cxx      2001/04/03 19:34:34     1.37
+++ compLoader.cxx      2001/06/22 05:27:14
@@ -239,7 +239,7 @@
             << " bytes from file offset "
             << make_numeric_attribute (file_offset, ios::hex | ios::showbase)
             << " into target " << who << " memory at "
-            << make_numeric_attribute ((void *)dest_addr, ios::hex | ios::showbase)
+            << make_numeric_attribute (dest_addr, ios::hex | ios::showbase)
             << endl;
     }
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]