This is the mail archive of the sid@sources.redhat.com mailing list for the SID project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [RFA] cfgroot usability improvement


Hi -

On Mon, May 21, 2001 at 02:11:15PM +1000, Ben Elliston wrote:
: [...]
: Okay to commit?

Good idea, except:


: + 		  if (++num_invalid_chars > 5)
: + 		    {
: + 		      emit_error ("too many invalid characters--possibly a binary file?");
: + 		      exit (1);
: + 		    }


cfgroot can't take it upon itself to *exit* the process.
Think of another way to abort the parsing process.


- FChE

PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]