This is the mail archive of the
mauve-patches@sourceware.org
mailing list for the Mauve project.
RFC: Fix java.awt.Dialog.size
- From: Omair Majid <omajid at redhat dot com>
- To: mauve-patches at sources dot redhat dot com
- Date: Mon, 23 Mar 2009 16:25:01 -0400
- Subject: RFC: Fix java.awt.Dialog.size
This patch fixes an issue in the java.awt.Dialog.size test where the
Dialog was shown and then a component was added to it, causing the
preferred size to become more than the actual size.
Works with IcedTea6 and gij 4.3.2
Changelog:
2009-03-23 Omair Majid <omajid@redhat.com>
* gnu/testlet/java/awt/Dialog/size.java (test): First add any
components to the Dialog, then pack it before testing preferred
size and actual size.
Cheers,
Omair
Index: gnu/testlet/java/awt/Dialog/size.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/java/awt/Dialog/size.java,v
retrieving revision 1.2
diff -u -r1.2 size.java
--- gnu/testlet/java/awt/Dialog/size.java 2 Nov 2005 16:38:22 -0000 1.2
+++ gnu/testlet/java/awt/Dialog/size.java 23 Mar 2009 20:11:13 -0000
@@ -37,8 +37,9 @@
public void test(TestHarness harness)
{
Dialog jd = new Dialog(new Frame());
- jd.show();
jd.add(new Label("Hello world"));
+ jd.pack();
+ jd.show();
// jd insets may be larger than preferred size
Dimension pref = jd.getPreferredSize();