This is the mail archive of the
mauve-patches@sourceware.org
mailing list for the Mauve project.
fix missing failures in XML output
- From: Christian Thalinger <twisti at complang dot tuwien dot ac dot at>
- To: mauve-patches ml <mauve-patches at sourceware dot org>
- Date: Wed, 11 Jun 2008 12:07:26 +0200
- Subject: fix missing failures in XML output
Hi!
This fixes missing failures in the XML output. Commited.
- twisti
---
Index: ChangeLog
===================================================================
RCS file: /cvs/mauve/mauve/ChangeLog,v
retrieving revision 1.2112
diff -u -3 -p -r1.2112 ChangeLog
--- ChangeLog 9 Jun 2008 13:54:35 -0000 1.2112
+++ ChangeLog 11 Jun 2008 10:05:17 -0000
@@ -1,3 +1,9 @@
+2008-06-11 Christian Thalinger <twisti@complang.tuwien.ac.at>
+
+ * RunnerProcess.java (check(Object, Object)): Changed code so we
+ don't have early returns and miss currentResult.addFail() calls.
+ This fixes a bug in missing failures in the XML output.
+
2008-06-09 Christian Thalinger <twisti@complang.tuwien.ac.at>
* gnu/testlet/java/security/AccessController/contexts.java (test):
Index: RunnerProcess.java
===================================================================
RCS file: /cvs/mauve/mauve/RunnerProcess.java,v
retrieving revision 1.17
diff -u -3 -p -r1.17 RunnerProcess.java
--- RunnerProcess.java 19 May 2008 08:19:34 -0000 1.17
+++ RunnerProcess.java 11 Jun 2008 10:05:17 -0000
@@ -546,19 +546,19 @@ public class RunnerProcess
lastFailureMessage = "\n got " + gotString
+ "\n\n but expected " + expString
+ "\n\n";
- System.out.println(lastFailureMessage);
- return;
}
else
{
- lastFailureMessage = "Objects were not equal";
- System.out.println("objects were not equal. " +
- "Use -debug for more information.");
- return;
+ lastFailureMessage = "Objects were not equal. " +
+ "Use -debug for more information.";
}
}
- lastFailureMessage = "got " + gotString + " but expected " + expString;
- currentResult.addFail(desc + " -- " +lastFailureMessage);
+ else
+ {
+ lastFailureMessage =
+ "got " + gotString + " but expected " + expString;
+ }
+ currentResult.addFail(desc + " -- " + lastFailureMessage);
System.out.println(lastFailureMessage);
}
}