This is the mail archive of the mauve-patches@sourceware.org mailing list for the Mauve project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: FYI: Test Fix


Joshua Sumali wrote:
This small patch fixes the timeout test in gnu/testlet/java/net/HttpURLConnection/

The test now passes on jamvm and openjdk.

2007-07-24 Joshua Sumali <jsumali@redhat.com>

   * gnu/testlet/java/net/HttpURLConnection/timeout.java:
   (testConnectTimeout): Fixed test.



------------------------------------------------------------------------

#P mauve
Index: gnu/testlet/java/net/HttpURLConnection/timeout.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/java/net/HttpURLConnection/timeout.java,v
retrieving revision 1.1
diff -u -r1.1 timeout.java
--- gnu/testlet/java/net/HttpURLConnection/timeout.java 8 Dec 2006 06:43:58 -0000 1.1
+++ gnu/testlet/java/net/HttpURLConnection/timeout.java 24 Jul 2007 13:17:57 -0000
@@ -248,7 +248,7 @@
// It should timeout.
long end = System.currentTimeMillis();
long delta = end - start;
- h.check((delta > 2000) && (delta < 5000));
+ h.check((delta > 0) && (delta < 5000));
}
} catch (IOException e)

I wonder if this could have been caused by the extra ':' in the url on line 233. Could you try changing the url from "http://10.20.30.40:/foo"; to "http://10.20.30.40/foo";, and see if that fixes the problem instead?


If not, I think the change you made is sensible.

Thanks
David Daney


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]