This is the mail archive of the mauve-patches@sourceware.org mailing list for the Mauve project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

FYI: Test Fix


This patch fixed an incorrect test in gnu/testlet/java/beans/Expression/check.java

A test in Expression was looking for a return value for the Array.set method, but
should not be since the method is public static void. Test now passes for java 1.4.2
and 1.5.


2007-07-10 Joshua Sumali <jsumali@redhat.com>

   * gnu/testlet/java/beans/Expression/check.java:
   (test):    Fixed incorrect test.


### Eclipse Workspace Patch 1.0
#P mauve
Index: gnu/testlet/java/beans/Expression/check.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/java/beans/Expression/check.java,v
retrieving revision 1.2
diff -u -r1.2 check.java
--- gnu/testlet/java/beans/Expression/check.java	4 Jul 2004 15:58:18 -0000	1.2
+++ gnu/testlet/java/beans/Expression/check.java	10 Jul 2007 13:49:52 -0000
@@ -145,9 +145,9 @@
       {
 	harness.fail("Expression set failed");
       }
-    harness.check(res4 instanceof Integer);
-    harness.check(((Integer)res4).intValue() == 3,
-		  "Test Expression of array and method named set");
+    //Array.set is public static void and should have no return value
+    harness.check(res4 == null);
+
     harness.check(iarray[2] == 6);
 
     Object arg5[] = { new Integer(2) };




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]