This is the mail archive of the mauve-patches@sourceware.org mailing list for the Mauve project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: FYI: Test Fix


Hey Mario!

On Sat, 2007-06-30 at 00:27 +0200, Mario Torre wrote:
> Hi Tania!
> 
> You are breaking Classpath!! :P
> 
> With Classpath CVS and JDK 1.6:
> 
> prior to the patch:
> 
> PASS: gnu.testlet.java.lang.Integer.parseInt (number 12)
> PASS: gnu.testlet.java.lang.Integer.parseInt (number 13)
> PASS: gnu.testlet.java.lang.Integer.parseInt (number 14)
> 
> after the patch:
> 
> FAIL: gnu.testlet.java.lang.Integer.parseInt: Leading '+' does not throw
> NumberFormatException (number 0)
> PASS: gnu.testlet.java.lang.Integer.parseInt: Leading '+' does not throw
> NumberFormatException (number 1)
> PASS: gnu.testlet.java.lang.Integer.parseInt: Leading '+' does not throw
> NumberFormatException (number 2)
> 
> So the test is wrong somewhere. I know that the javadoc for java 7
> states that '+' is a valid character, but I think this is too much a
> work in progress to include it as a test, removing old tests, especially
> if this ends up that current stable version fails, while development
> snapshots (whose specs may change at any time) works. I would wait to
> see that finalized, or just write a test specifically for IcedTea.
> 
> If you think there is a reason to break current behaviour ahead of time,
> please, go further and don't listen to me, but in this case I guess that
> a patch for classpath to fix it is needed too.
> 
> Of course, this is only my opinion.

You are right!  If only '+' is passed as an argument to
java.lang.parseInt(String) a NumberFormatException should be thrown.
Currently, the reference implementation does not throw such error in
this case, so, I didn't want to submit a patch to classpath just yet.  

On Friday, I submitted a new bug report to Sun and they're responded
stating that this is a new bug.  Here is the link:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6576055.  I will be
submitting a patch to classpath shortly.

Hope this makes sense!

Cheers,
Tania


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]