Re: FYI: Test Fix

[Mario Torre <neugens at limasoftware dot net>]

Il giorno ven, 29/06/2007 alle 15.38 -0400, Tania Bento ha scritto:
> This patch fixes an incorrect test in
> gnu.testlet.java.lang.Integer.parseInt.
> 
> 
> 2007-06-29  Tania Bento  <tbento@redhat.com>
> 
>         * gnu/testlet/java/lang/Integer/parsetInt.java:
>         (test):  Fixed incorrect test.

Hi Tania!

You are breaking Classpath!! :P

With Classpath CVS and JDK 1.6:

prior to the patch:

PASS: gnu.testlet.java.lang.Integer.parseInt (number 12)
PASS: gnu.testlet.java.lang.Integer.parseInt (number 13)
PASS: gnu.testlet.java.lang.Integer.parseInt (number 14)

after the patch:

FAIL: gnu.testlet.java.lang.Integer.parseInt: Leading '+' does not throw
NumberFormatException (number 0)
PASS: gnu.testlet.java.lang.Integer.parseInt: Leading '+' does not throw
NumberFormatException (number 1)
PASS: gnu.testlet.java.lang.Integer.parseInt: Leading '+' does not throw
NumberFormatException (number 2)

So the test is wrong somewhere. I know that the javadoc for java 7
states that '+' is a valid character, but I think this is too much a
work in progress to include it as a test, removing old tests, especially
if this ends up that current stable version fails, while development
snapshots (whose specs may change at any time) works. I would wait to
see that finalized, or just write a test specifically for IcedTea.

If you think there is a reason to break current behaviour ahead of time,
please, go further and don't listen to me, but in this case I guess that
a patch for classpath to fix it is needed too.

Of course, this is only my opinion.

Ciao!
Mario
-- 
Lima Software - http://www.limasoftware.net/
GNU Classpath Developer - http://www.classpath.org/
Fedora Ambassador - http://fedoraproject.org/wiki/MarioTorre
Jabber: neugens@jabber.org
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF

Please, support open standards:
http://opendocumentfellowship.org/petition/
http://www.nosoftwarepatents.com/

Attachment: signature.asc
Description: Questa =?ISO-8859-1?Q?=E8?= una parte del messaggiofirmata digitalmente