This is the mail archive of the
mauve-patches@sourceware.org
mailing list for the Mauve project.
FYI: JTable and SizeSequence - new tests
- From: David Gilbert <david dot gilbert at object-refinery dot com>
- To: mauve-patches at sources dot redhat dot com
- Date: Fri, 22 Sep 2006 12:16:28 +0100
- Subject: FYI: JTable and SizeSequence - new tests
This patch (committed) adds a couple of tests for the JTable class and updates one
test for the SizeSequence class:
2006-09-22 David Gilbert <david.gilbert@object-refinery.com>
* gnu/testlet/javax/swing/SizeSequence/getSize.java
(test): Check indices out of bounds,
* gnu/testlet/javax/swing/JTable/getRowHeight.java: New test,
* gnu/testlet/javax/swing/JTable/setRowHeight.java: New test.
I have a small GNU Classpath patch for the SizeSequence class that will fix the
failing checks.
Regards,
Dave
Index: gnu/testlet/javax/swing/JTable/getRowHeight.java
===================================================================
RCS file: gnu/testlet/javax/swing/JTable/getRowHeight.java
diff -N gnu/testlet/javax/swing/JTable/getRowHeight.java
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ gnu/testlet/javax/swing/JTable/getRowHeight.java 22 Sep 2006 11:09:53 -0000
@@ -0,0 +1,65 @@
+/* getRowHeight.java -- some checks for the getRowHeight() method in the
+ JTable class.
+ Copyright (C) 2006 David Gilbert <david.gilbert@object-refinery.com>
+This file is part of Mauve.
+
+Mauve is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2, or (at your option)
+any later version.
+
+Mauve is distributed in the hope that it will be useful, but
+WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with Mauve; see the file COPYING. If not, write to the
+Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+02110-1301 USA.
+
+*/
+
+// Tags: JDK1.5
+
+package gnu.testlet.javax.swing.JTable;
+
+import gnu.testlet.TestHarness;
+import gnu.testlet.Testlet;
+
+import javax.swing.JTable;
+
+public class getRowHeight implements Testlet
+{
+ public void test(TestHarness harness)
+ {
+ test1(harness);
+ test2(harness);
+ }
+
+ public void test1(TestHarness harness)
+ {
+ harness.checkPoint("()");
+ JTable t = new JTable(4, 3);
+ harness.check(t.getRowHeight(), 16);
+ t.setRowHeight(99);
+ harness.check(t.getRowHeight(), 99);
+ }
+
+ public void test2(TestHarness harness)
+ {
+ harness.checkPoint("(int)");
+ JTable t = new JTable(4, 3);
+ harness.check(t.getRowHeight(0), 16);
+ t.setRowHeight(99);
+ harness.check(t.getRowHeight(0), 99);
+ t.setRowHeight(0, 12);
+ harness.check(t.getRowHeight(0), 12);
+
+ // try negative index
+ harness.check(t.getRowHeight(-1), 0);
+
+ // try index too large
+ harness.check(t.getRowHeight(4), 0);
+ }
+}
Index: gnu/testlet/javax/swing/JTable/setRowHeight.java
===================================================================
RCS file: gnu/testlet/javax/swing/JTable/setRowHeight.java
diff -N gnu/testlet/javax/swing/JTable/setRowHeight.java
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ gnu/testlet/javax/swing/JTable/setRowHeight.java 22 Sep 2006 11:09:53 -0000
@@ -0,0 +1,76 @@
+/* setRowHeight.java -- some checks for the setRowHeight() method in the
+ JTable class.
+ Copyright (C) 2006 David Gilbert <david.gilbert@object-refinery.com>
+This file is part of Mauve.
+
+Mauve is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2, or (at your option)
+any later version.
+
+Mauve is distributed in the hope that it will be useful, but
+WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with Mauve; see the file COPYING. If not, write to the
+Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+02110-1301 USA.
+
+*/
+
+// Tags: JDK1.5
+
+package gnu.testlet.javax.swing.JTable;
+
+import javax.swing.JTable;
+
+import gnu.testlet.TestHarness;
+import gnu.testlet.Testlet;
+
+public class setRowHeight implements Testlet
+{
+ public void test(TestHarness harness)
+ {
+ test1(harness);
+ test2(harness);
+ }
+
+ public void test1(TestHarness harness)
+ {
+ harness.checkPoint(("int"));
+ JTable t = new JTable(4, 3);
+ harness.check(t.getRowHeight(0), 16);
+ t.setRowHeight(99);
+ harness.check(t.getRowHeight(0), 99);
+
+ // does this row height override individual row heights?
+ t.setRowHeight(1, 13);
+ harness.check(t.getRowHeight(1), 13);
+ t.setRowHeight(14);
+ harness.check(t.getRowHeight(1), 14);
+
+ // try zero
+ boolean pass = false;
+ try
+ {
+ t.setRowHeight(0);
+ }
+ catch (IllegalArgumentException e)
+ {
+ pass = true;
+ }
+ harness.check(pass);
+ }
+
+ public void test2(TestHarness harness)
+ {
+ harness.checkPoint("(int, int)");
+ JTable t = new JTable(4, 3);
+ harness.check(t.getRowHeight(0), 16);
+ t.setRowHeight(99);
+ harness.check(t.getRowHeight(0), 99);
+
+ }
+}
Index: gnu/testlet/javax/swing/SizeSequence/getSize.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/javax/swing/SizeSequence/getSize.java,v
retrieving revision 1.1
diff -u -r1.1 getSize.java
--- gnu/testlet/javax/swing/SizeSequence/getSize.java 16 May 2006 20:32:30 -0000 1.1
+++ gnu/testlet/javax/swing/SizeSequence/getSize.java 22 Sep 2006 11:09:53 -0000
@@ -37,5 +37,14 @@
harness.check(s.getSize(0), 1);
harness.check(s.getSize(1), 2);
harness.check(s.getSize(2), 3);
+
+ // the spec states that indices outside the valued range have no specified
+ // behaviour, but they seem to return zero...
+
+ // try negative index
+ harness.check(s.getSize(-1), 0);
+
+ // try index too large
+ harness.check(s.getSize(3), 0);
}
}