This is the mail archive of the
mauve-patches@sourceware.org
mailing list for the Mauve project.
FYI: BasicArrowButton test updates
- From: David Gilbert <david dot gilbert at object-refinery dot com>
- To: mauve-patches <mauve-patches at sources dot redhat dot com>
- Date: Fri, 07 Jul 2006 14:39:07 +0100
- Subject: FYI: BasicArrowButton test updates
This patch (committed) adds some more checks for the
getMax/Min/PreferredSize() methods:
2006-07-07 David Gilbert <david.gilbert@object-refinery.com>
*
gnu/testlet/javax/swing/plaf/basic/BasicArrowButton/getMaximumSize.java
(test): Check modification of return value,
*
gnu/testlet/javax/swing/plaf/basic/BasicArrowButton/getMinimumSize.java
(test): Likewise,
*
gnu/testlet/javax/swing/plaf/basic/BasicArrowButton/getPreferredSize.java
(test): Likewise.
Regards,
Dave
Index: gnu/testlet/javax/swing/plaf/basic/BasicArrowButton/getMaximumSize.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/javax/swing/plaf/basic/BasicArrowButton/getMaximumSize.java,v
retrieving revision 1.1
diff -u -r1.1 getMaximumSize.java
--- gnu/testlet/javax/swing/plaf/basic/BasicArrowButton/getMaximumSize.java 9 Sep 2005 04:34:53 -0000 1.1
+++ gnu/testlet/javax/swing/plaf/basic/BasicArrowButton/getMaximumSize.java 7 Jul 2006 13:35:50 -0000
@@ -1,6 +1,6 @@
// Tags: JDK1.2
-// Copyright (C) 2005 David Gilbert <david.gilbert@object-refinery.com>
+// Copyright (C) 2005, 2006, David Gilbert <david.gilbert@object-refinery.com>
// This file is part of Mauve.
@@ -50,8 +50,13 @@
// setting the maximum size explicitly has no effect
b.setMaximumSize(new Dimension(12, 34));
harness.check(b.getMaximumSize(), new Dimension(Integer.MAX_VALUE,
- Integer.MAX_VALUE));
+ Integer.MAX_VALUE));
+ // modifying the returned value should not affect the button
+ Dimension m = b.getMaximumSize();
+ m.setSize(1, 2);
+ harness.check(b.getMaximumSize(), new Dimension(Integer.MAX_VALUE,
+ Integer.MAX_VALUE));
}
}
Index: gnu/testlet/javax/swing/plaf/basic/BasicArrowButton/getMinimumSize.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/javax/swing/plaf/basic/BasicArrowButton/getMinimumSize.java,v
retrieving revision 1.1
diff -u -r1.1 getMinimumSize.java
--- gnu/testlet/javax/swing/plaf/basic/BasicArrowButton/getMinimumSize.java 9 Sep 2005 04:34:53 -0000 1.1
+++ gnu/testlet/javax/swing/plaf/basic/BasicArrowButton/getMinimumSize.java 7 Jul 2006 13:35:50 -0000
@@ -1,6 +1,6 @@
// Tags: JDK1.2
-// Copyright (C) 2005 David Gilbert <david.gilbert@object-refinery.com>
+// Copyright (C) 2005, 2006, David Gilbert <david.gilbert@object-refinery.com>
// This file is part of Mauve.
@@ -49,6 +49,11 @@
// setting the minimum size explicitly has no effect
b.setMinimumSize(new Dimension(12, 34));
harness.check(b.getMinimumSize(), new Dimension(5, 5));
+
+ // modifying the returned value should not affect the button
+ Dimension m = b.getMinimumSize();
+ m.setSize(1, 2);
+ harness.check(b.getMinimumSize(), new Dimension(5, 5));
}
}
Index: gnu/testlet/javax/swing/plaf/basic/BasicArrowButton/getPreferredSize.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/javax/swing/plaf/basic/BasicArrowButton/getPreferredSize.java,v
retrieving revision 1.1
diff -u -r1.1 getPreferredSize.java
--- gnu/testlet/javax/swing/plaf/basic/BasicArrowButton/getPreferredSize.java 9 Sep 2005 04:34:53 -0000 1.1
+++ gnu/testlet/javax/swing/plaf/basic/BasicArrowButton/getPreferredSize.java 7 Jul 2006 13:35:50 -0000
@@ -1,6 +1,6 @@
// Tags: JDK1.2
-// Copyright (C) 2005 David Gilbert <david.gilbert@object-refinery.com>
+// Copyright (C) 2005, 2006, David Gilbert <david.gilbert@object-refinery.com>
// This file is part of Mauve.
@@ -49,6 +49,11 @@
// setting the preferred size explicitly has no effect
b.setPreferredSize(new Dimension(12, 34));
harness.check(b.getPreferredSize(), new Dimension(16, 16));
+
+ // modifying the returned value should not affect the button
+ Dimension p = b.getPreferredSize();
+ p.setSize(1, 2);
+ harness.check(b.getPreferredSize(), new Dimension(16, 16));
}
}