This is the mail archive of the mauve-patches@sourceware.org mailing list for the Mauve project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: New Lightweight tests


On Wed, 2006-02-22 at 10:04 +0000, David Gilbert wrote:
> Hi Lillian,
> 
> I wonder if these methods should really be added to TestHarness, they 
> seem a little too "specialised" to me (especially the rectangle corner 
> color tests), and it would be nice to keep TestHarness as simple as 
> possible. 

Tom asked me to add these, because they will be used in the future. As
of now, they are used in two different tests.

>  Maybe you could create a utility class in 
> gnu.testlet.java.awt.* that contains static methods that perform these 
> checks?  Then you could share that between your Frame and Container tests.
> 

Yes, I could do that. I'll speak to Tom and see what he prefers

Lillian

> Regards,
> 
> Dave
> 
> Lillian Angel wrote:
> 
> >On Tue, 2006-02-21 at 18:52 -0500, Lillian Angel wrote:
> >  
> >
> >>I added new tests for Lightweight Containers.
> >>    
> >>
> >
> >I forgot to mention, I added some new methods to TestHarness. These
> >methods are helpful for testing locations on the screen when using
> >Lightweight/Heavyweight widgets. It made sense to add these to
> >TestHarness, since they are used in Frame and Container.
> >
> >  
> >
> >>2006-02-21  Lillian Angel  <langel@redhat.com>
> >>
> >>        * gnu/testlet/TestHarness.java
> >>        (checkColor): New method used to compare colors.
> >>        (checkRectangleOuterColors): New method used to compare the
> >>        colors of a rectangle's corners to the colors of the pixels
> >>        surrounding the corners.
> >>        (checkRectangleCornerColors): New method used to compare
> >>        the colors of the pixels at the corners of a rectangle, to
> >>        a given color.
> >>        * gnu/testlet/java/awt/Container/LightweightContainer.java:
> >>        New Test.
> >>        * gnu/testlet/java/awt/Frame/size1.java
> >>        (checkColor): Removed.
> >>        (test): Changed to use new methods in TestHarness.
> >>
> >>    
> >>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]