This is the mail archive of the
mauve-patches@sourceware.org
mailing list for the Mauve project.
FYI: JComponent.getListeners() - new check
- From: David Gilbert <david dot gilbert at object-refinery dot com>
- To: mauve-patches at sources dot redhat dot com
- Date: Tue, 14 Feb 2006 11:08:59 +0000
- Subject: FYI: JComponent.getListeners() - new check
This patch (committed) adds another check for the getListeners() method,
specifically for the retrieval of PropertyChangeListeners. The check
passes when run on JDK1.5 but currently fails for GNU Classpath:
2006-02-14 David Gilbert <david.gilbert@object-refinery.com>
* gnu/testlet/javax/swing/JComponent/getListeners.java
(MyPropertyChangeListener): New class,
(test): Added check for PropertyChangeListener.
Regards,
Dave
Index: gnu/testlet/javax/swing/JComponent/getListeners.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/javax/swing/JComponent/getListeners.java,v
retrieving revision 1.1
diff -u -r1.1 getListeners.java
--- gnu/testlet/javax/swing/JComponent/getListeners.java 23 Nov 2005 15:31:26 -0000 1.1
+++ gnu/testlet/javax/swing/JComponent/getListeners.java 14 Feb 2006 10:59:10 -0000
@@ -1,6 +1,6 @@
// Tags: JDK1.3
-// Copyright (C) 2005 David Gilbert <david.gilbert@object-refinery.com>
+// Copyright (C) 2005, 2006 David Gilbert <david.gilbert@object-refinery.com>
// Mauve is free software; you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
@@ -22,8 +22,9 @@
import gnu.testlet.TestHarness;
import gnu.testlet.Testlet;
-import java.awt.event.ContainerListener;
import java.awt.event.FocusListener;
+import java.beans.PropertyChangeEvent;
+import java.beans.PropertyChangeListener;
import java.util.EventListener;
import javax.swing.JComponent;
@@ -39,6 +40,15 @@
class TestComponent extends JComponent
{
}
+
+ class MyPropertyChangeListener
+ implements PropertyChangeListener
+ {
+ public void propertyChange(PropertyChangeEvent e)
+ {
+ // ignore
+ }
+ }
/**
* Runs the test using the specified harness.
@@ -52,6 +62,7 @@
EventListener[] listeners = c.getListeners(AncestorListener.class);
harness.check(listeners.length, 1);
harness.check(listeners[0], this);
+
// try a listener type that isn't registered
listeners = c.getListeners(FocusListener.class);
harness.check(listeners.length, 0);
@@ -59,6 +70,16 @@
listeners = c.getListeners(AncestorListener.class);
harness.check(listeners.length, 0);
+ // try a PropertyChangeListener
+ PropertyChangeListener pcl = new MyPropertyChangeListener();
+ c.addPropertyChangeListener(pcl);
+ listeners = c.getListeners(PropertyChangeListener.class);
+ harness.check(listeners.length, 1);
+ if (listeners.length > 0)
+ harness.check(listeners[0], pcl);
+ else
+ harness.check(false);
+
// try a null argument
boolean pass = false;
try