Re: java.util.Arrays

[Mark Wielaard <mark at klomp dot org>]

Hi Dave,

On Fri, 2004-08-27 at 18:25, David Gilbert wrote:
> For the java.util.Arrays class, I've attached three new tests and
> patches for the two existing tests (both patches add further checks). 

Thanks checked in as:

2004-08-27  David Gilbert  <david.gilbert@object-refinery.com>

        * gnu/testlet/java/util/Arrays/asList.java: New tests.
        * gnu/testlet/java/util/Arrays/binarySearch.java: Likewise.
        * gnu/testlet/java/util/Arrays/fill.java: Likewise.
        * gnu/testlet/java/util/Arrays/equals.java (testBoolean): New test.
        (testByte): Likewise.
        (testChar): Likewise.
        (testDouble): Likewise.
        (testFloat): Likewise.
        (testInt): Likewise.
        (testLong): Likewise.
        (testObject): Likewise.
        (testShort): Likewise.
        * gnu/testlet/java/util/Arrays/sort.java (testByte): New test.
        (testChar): Likewise.
        (testDouble): likewise.
        (testFloat): Likewise.
        (testInt): Likewise.
        (testLong): Likewise.
        (testObject): Likewise.
        (testShort): Likewise.

(For sort.java I added a note that the original was written by tom
Tromey with some additions by John Leuner.)

> With JamVM 1.1.4 I get a number of failures.  The first two I think are
> due to a bug in JamVM (see my post earlier today re: Float.compare() and
> Double.compare()).

Yep, they disappear with the jamvm pre-release I have here.

>   I haven't investigated the other failures in detail,
> but they are all very similar and probably have the same underlying
> cause (I may have some time next week to look at this more closely).

Woopsie. If the array is short then sort() uses insertion sort not quick
sort in GNU Classpath. The insertion sort variant doesn't correctly use
the from index. Working on a fix.

Thanks,

Mark

Attachment: signature.asc
Description: This is a digitally signed message part