Re: Tests for Arc2D class

[Mark Wielaard <mark at klomp dot org>]

On Mon, 2004-08-09 at 12:59, David Gilbert wrote:
> Please find attached a set of tests for the Arc2D class.

Thanks again. Committed as:

2004-08-09  David Gilbert  <david.gilbert@object-refinery.com>

       * gnu/testlet/java/awt/geom/Arc2D/clone.java: New test.
       * gnu/testlet/java/awt/geom/Arc2D/constants.java: Likewise.
       * gnu/testlet/java/awt/geom/Arc2D/constructors.java: Likewise.
       * gnu/testlet/java/awt/geom/Arc2D/contains.java: Likewise.
       * gnu/testlet/java/awt/geom/Arc2D/containsAngle.java: Likewise.
       * gnu/testlet/java/awt/geom/Arc2D/equals.java: Likewise.
       * gnu/testlet/java/awt/geom/Arc2D/getBounds2D.java: Likewise.
       * gnu/testlet/java/awt/geom/Arc2D/getEndPoint.java: Likewise.
       * gnu/testlet/java/awt/geom/Arc2D/getPathIterator.java: Likewise.
       * gnu/testlet/java/awt/geom/Arc2D/getStartPoint.java: Likewise.
       * gnu/testlet/java/awt/geom/Arc2D/intersects.java: Likewise.
       * gnu/testlet/java/awt/geom/Arc2D/isEmpty.java: Likewise.
       * gnu/testlet/java/awt/geom/Arc2D/setAngleExtent.java: Likewise.
       * gnu/testlet/java/awt/geom/Arc2D/setAngleStart.java: Likewise.
       * gnu/testlet/java/awt/geom/Arc2D/setAngles.java: Likewise.
       * gnu/testlet/java/awt/geom/Arc2D/setArc.java: Likewise.
       * gnu/testlet/java/awt/geom/Arc2D/setArcByCenter.java: Likewise.
       * gnu/testlet/java/awt/geom/Arc2D/setArcByTangent.java: Likewise.
       * gnu/testlet/java/awt/geom/Arc2D/setArcType.java: Likewise.
       * gnu/testlet/java/awt/geom/Arc2D/setFrame.java: Likewise.

> In Classpath, the Arc2D implementation is not complete, so there are some
> failures.  I believe Sven de Marothy is working on this class, so
> hopefully these tests will be helpful for that effort.

Yes, at least contains(), intersects() and setArcByTangent() have not
yet been implemented. But the setAngles() failures look like real bugs
and the following two failures (under kaffe) look like subtle floating
point errors in the runtime:

FAIL: gnu.testlet.java.awt.geom.Arc2D.getEndPoint (number 1)
got 6.123031769111886E-17 but expected 0.0
FAIL: gnu.testlet.java.awt.geom.Arc2D.getPathIterator (number 8)
got 2.895430500338413 but expected 2.8954305003384135

Thanks again for the tests, they will be very helpful to track down some
bugs!

Cheers,

Mark

Attachment: signature.asc
Description: This is a digitally signed message part