This is the mail archive of the mauve-patches@sources.redhat.com mailing list for the Mauve project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Test cases for Line2D class


Hi David,

On Mon, 2004-08-02 at 14:43, David Gilbert wrote:
> First contribution from me...

And a very nice one! Thanks for all these new tests.
I checked it in as follows:

2004-08-06  David Gilbert  <david.gilbert@object-refinery.com>

        * gnu/testlet/java/awt/geom/Line2D/clone.java: New test.
        * gnu/testlet/java/awt/geom/Line2D/contains.java: Likewise.
        * gnu/testlet/java/awt/geom/Line2D/equals.java: Likewise.
        * gnu/testlet/java/awt/geom/Line2D/getBounds.java: Likewise.
        * gnu/testlet/java/awt/geom/Line2D/getP1.java: Likewise.
        * gnu/testlet/java/awt/geom/Line2D/getP2.java: Likewise.
        * gnu/testlet/java/awt/geom/Line2D/getPathIterator.java: Likewise.
        * gnu/testlet/java/awt/geom/Line2D/intersects.java: Likewise.
        * gnu/testlet/java/awt/geom/Line2D/intersectsLine.java: Likewise.
        * gnu/testlet/java/awt/geom/Line2D/ptLineDist.java: Likewise.
        * gnu/testlet/java/awt/geom/Line2D/ptLineDistSq.java: Likewise.
        * gnu/testlet/java/awt/geom/Line2D/ptSegDist.java: Likewise.
        * gnu/testlet/java/awt/geom/Line2D/ptSegDistSq.java: Likewise.
        * gnu/testlet/java/awt/geom/Line2D/relativeCCW.java: Likewise.
        * gnu/testlet/java/awt/geom/Line2D/setLine.java: Likewise.

With jamvm/kissme/gij with recent GNU Classpath I get the following failures:

FAIL: gnu.testlet.java.awt.geom.Line2D.intersectsLine (number 1)
FAIL: gnu.testlet.java.awt.geom.Line2D.intersectsLine (number 3)
FAIL: gnu.testlet.java.awt.geom.Line2D.intersectsLine (number 4)
FAIL: gnu.testlet.java.awt.geom.Line2D.intersectsLine (number 6)
FAIL: gnu.testlet.java.awt.geom.Line2D.intersectsLine (number 8)
FAIL: gnu.testlet.java.awt.geom.Line2D.intersectsLine (number 9)
FAIL: gnu.testlet.java.awt.geom.Line2D.linesIntersect (number 1)
FAIL: gnu.testlet.java.awt.geom.Line2D.linesIntersect (number 2)
FAIL: gnu.testlet.java.awt.geom.Line2D.linesIntersect (number 3)
FAIL: gnu.testlet.java.awt.geom.Line2D.linesIntersect (number 4)

For older versions of GNU Classpath it also catches these failures (now fixed):

FAIL: gnu.testlet.java.awt.geom.Line2D.getPathIterator (number 1)
FAIL: gnu.testlet.java.awt.geom.Line2D.getPathIterator (number 5)
FAIL: gnu.testlet.java.awt.geom.Line2D.getPathIterator (number 9)

> P.S.  I have completed the FSF paperwork for contributing to Classpath,
> is this a requirement for Mauve also?

No, for Mauve we are less strict. But see
http://sources.redhat.com/mauve/contribute.html:

        Contributing to Mauve is fairly easy -- we're pretty generous
        with cvs write access, and we don't require copyright
        assignments or anything like that. We do ask that you not have
        read Sun's source; we are a cleanroom test suite and we're
        concerned about contamination.

The reason we are a bit less strict about getting all this in writing is
because we can in principle remove any tests from Mauve without
inconveniencing our users too much, if at a later point there happens to
be any unclarity where a patch came from, who contributed it and/or if
they were allowed to contribute it. But removing things from the core
libraries impacts our users a lot. So for those we go through the whole
paperwork routine just to make sure that we have a paper trail and
accountability of what came from where exactly.

Thanks,

Mark

Attachment: signature.asc
Description: This is a digitally signed message part


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]