This is the mail archive of the mailing list for the Mauve project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Bug in getEncoding testcase

Hi Torben,

Thanks for following this up. Robert Schuster wrote the original test so I suggest we ask him to review your patch (I've cc'ed him). Sending the patch to mauve-patches was the right thing to do, it just didn't work out this time (unfortunately).


Dave Gilbert wrote:

A few weeks ago I posted this patch to mauve-patches. Since it is still
unchanged in cvs, I would like to ask if I posted to the wrong list, or
if there is a problem with the patch. The problem with the existing
is that contradictory to the test description in the top of the file, it
requires the extended charsets to be present, causing numerous false error

Index: gnu/testlet/java/io/InputStreamReader/
RCS file:
retrieving revision 1.1
diff -u -F^f -r1.1
--- gnu/testlet/java/io/InputStreamReader/      17 Jun 2005
01:49:48 -0000      1.1
+++ gnu/testlet/java/io/InputStreamReader/      7 Sep 2005
14:06:06 -0000
@@ -165,8 +165,8 @@
                       } catch (UnsupportedCharsetException uce) {
                               supported = false;
-                       harness.check(name, extIoNames[i]);
-                       harness.check(supported, true);
+                       if ( supported )
+                               harness.check(name, extIoNames[i]);

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]