This is the mail archive of the mauve-discuss@sources.redhat.com mailing list for the Mauve project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: new -file option to SimpleTestHarness


-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160

On Friday 20 December 2002 03:04, Brian Jones wrote:
> ...
> You need to get rid of this BufferedReader r = new ... before your
> additions. If the file argument is given and the file does not exist,
> report the error and exit maybe... ?  Failing over to stdin doesn't
> seem logical.

diff -u -wb -B ../mauve/mauve/gnu/testlet/SimpleTestHarness.java source/gnu/testlet/SimpleTestHarness.java
- --- ../mauve/mauve/gnu/testlet/SimpleTestHarness.java   2002-11-15 20:05:47.000000000 +1100
+++ source/gnu/testlet/SimpleTestHarness.java   2002-12-20 05:16:26.000000000 +1100
@@ -286,6 +286,7 @@
       boolean verbose = false;
       boolean debug = false;
       boolean results_only = false;
+      String file = null;
       int i;

       for (i = 0; i < args.length; i++)
@@ -300,6 +301,15 @@
              verbose = false;
              debug = false;
            }
+          else if (args[i].equalsIgnoreCase("-file"))
+            try
+            {
+              file = args[++i];
+            }
+            catch (Exception x)
+            {
+              throw new RuntimeException ("Missing file path after '-file'. Exit");
+            }
          else
            break;
         }
@@ -307,8 +317,18 @@
       SimpleTestHarness harness
        = new SimpleTestHarness (verbose, debug, results_only);

- -      BufferedReader r
- -       = new BufferedReader (new InputStreamReader (System.in));
+      BufferedReader r = null;
+      if (file != null)
+        try
+        {
+          r = new BufferedReader (new FileReader (file));
+        }
+        catch (FileNotFoundException x)
+        {
+          throw new RuntimeException ("Unable to find \""+file+"\". Exit");
+        }
+      else
+        r = new BufferedReader (new InputStreamReader (System.in));
       while (true)
        {
          String cname = null;
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)
Comment: Que du magnifique

iD8DBQE+Ag5X+e1AKnsTRiERAzISAJ9gWfVRDzj1uEggEywtej4QLaSeUQCeIl+W
/bMYMGPahQ3YGPKj3aS45M8=
=r+Gb
-----END PGP SIGNATURE-----


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]