This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH roland/arm-mcount] ARM: Disable compat mcount code when unneeded.
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: <libc-ports at sourceware dot org>, "GNU C. Library" <libc-alpha at sourceware dot org>
- Date: Fri, 10 Jan 2014 21:54:39 +0000
- Subject: Re: [PATCH roland/arm-mcount] ARM: Disable compat mcount code when unneeded.
- Authentication-results: sourceware.org; auth=none
- References: <20130827173014 dot D264D2C097 at topped-with-meat dot com> <Pine dot LNX dot 4 dot 64 dot 1308291219461 dot 32214 at digraph dot polyomino dot org dot uk> <20130829232658 dot 5B2002C072 at topped-with-meat dot com> <Pine dot LNX dot 4 dot 64 dot 1308292337500 dot 1487 at digraph dot polyomino dot org dot uk> <20140110213420 dot A949574419 at topped-with-meat dot com>
On Fri, 10 Jan 2014, Roland McGrath wrote:
> I've done an arm-linux-gnueabi build and verified that arm-mcount.o{,s}
> have no differences except for the addition of the __mcount_arm_compat
> symbol, and that 'make check-abi' still passes.
>
> I've done an arm-linux-gnueabihf build and verified that arm-mcount.o has
> no differences except the removal of the _mcount code and the mcount alias,
> and that arm-mcount.os has no differences except in its symbol table, and
> that 'make check-abi' still passes. That is, the one user-visible change
> here is that the symbols _mcount and mcount are no longer available at link
> time (either static or dynamic) for arm-linux-gnueabihf. Does that merit a
> NEWS mention?
I don't think a NEWS mention is needed; making symbols no longer available
at link time should get a mention if users might have used them directly,
but I don't see a need where the symbols couldn't sensibly have been
called directly from user C code.
The change is OK with me for 2.19, since there's still another ARM issue
pending before doing ARM release testing for 2.19.
--
Joseph S. Myers
joseph@codesourcery.com