This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH, COMMITTED] BZ #15128 [AArch64] Save and restore q0-q7 on entry to dynamic linker.
- From: Andrew Pinski <pinskia at gmail dot com>
- To: Marcus Shawcroft <marcus dot shawcroft at linaro dot org>
- Cc: libc-ports <libc-ports at sourceware dot org>
- Date: Mon, 6 Jan 2014 14:04:03 -0800
- Subject: Re: [PATCH, COMMITTED] BZ #15128 [AArch64] Save and restore q0-q7 on entry to dynamic linker.
- Authentication-results: sourceware.org; auth=none
- References: <CABXK9nd0E6gs1Ho4+0CeSsGic5KxyfB9z3JVDANtw4DC4kdHag at mail dot gmail dot com>
On Wed, Dec 18, 2013 at 4:05 AM, Marcus Shawcroft
<marcus.shawcroft@linaro.org> wrote:
> This patch ensures that all argument passing registers are saved and
> restored on entry to the dynamic linker and resolves BZ #15128.
>
> Regression tested. Committed to trunk. Back port to 2.18 branch will follow.
There is a bug in this patch:
- stp x8, x9, [sp, #-80]!
+ stp x8, x9, [sp, #-(80+8*16)]!
cfi_adjust_cfa_offset (80)
You forgot to update the cfi_adjust_cfa_offset to be 80+8*16.
Thanks,
Andrew Pinski
>
> Cheers
> /Marcus