This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Hi Marcus, Thank you for reviewing the patch. I have incorporated your review comments. (Snip) +#ifdef PTR_DEMANGLE + PTR_DEMANGLE (sp); +#endif Nested #if should have indentation between # and if. (Snip) In ports/sysdeps/aarch64/jmpbuf-offsets.h, should I need to add space between # and if? Reading the glibc coding style, I understood it as outer #ifndef __ASSEMBLER__ will not increase indentation level. if it is Ok, can you please commit on my behalf since I don't have write access. ChangeLog.aarch64: ----------------------------- 2013-12-31 Venkataramanan Kumar <venkataramanan.kumar@linaro.org> * sysdeps/aarch64/__longjmp.S (__longjmp): Demangle sp and lr when restoring register values. * sysdeps/aarch64/setjmp.S (__sigsetjmp): Mangle sp and lr before storing register values. * sysdeps/arm/jmpbuf-unwind.h (_jmpbuf_sp): Remove. * sysdeps/aarch64/jmpbuf-offsets.h (_jmpbuf_sp): Add. (JB_FRAME_ADDRESS): call _jmpbuf_sp. * sysdeps/aarch64/sysdep.h (LDST_PCREL) : New macros. (LDST_GLOBAL): Likewise. * sysdeps/unix/sysv/linux/aarch64/sysdep.h (PTR_MANGLE): New macro. (PTR_DEMANGLE): Likewise. (PTR_MANGLE2): Likewise. (PTR_DEMANGLE2): Likewise. regards, Venkat. On 31 December 2013 03:50, Marcus Shawcroft <marcus.shawcroft@gmail.com> wrote: > Hi, Couple of nits: > > On 30 December 2013 05:00, Venkataramanan Kumar > <venkataramanan.kumar@linaro.org> wrote: > > +# define PTR_MANGLE(dst, src, guard, tmp) \ > + LDST_PCREL(ldr, guard, tmp, C_SYMBOL_NAME(__pointer_chk_guard_local)); \ > + PTR_MANGLE2(dst, src, guard) > > Space before ( in macro invocations. > > +#ifdef PTR_DEMANGLE > + PTR_DEMANGLE (sp); > +#endif > > Nested #if should have indentation between # and if. > > +/* Pointer mangling is support for AArch64. */ > > support -> supported > > Otherwise OK > /Marcus
Attachment:
aarch64.glibc.pointer.mangle.txt
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |