This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: All machines: Pointer guard testing update (Bug 15754, CVE-2013-4788).
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>
- Cc: libc-ports at sourceware dot org, thomas at codesourcery dot com
- Date: Thu, 26 Sep 2013 21:42:58 -0400
- Subject: Re: All machines: Pointer guard testing update (Bug 15754, CVE-2013-4788).
- Authentication-results: sourceware.org; auth=none
- References: <52444A27 dot 7050500 at redhat dot com> <20130927 dot 100635 dot 215380609 dot kkojima at rr dot iij4u dot or dot jp>
On 09/26/2013 09:06 PM, Kaz Kojima wrote:
> Hi,
>
> "Carlos O'Donell" <carlos@redhat.com> wrote:
>> My request is that you run the testsuite and verify that
>> tst-ptrguard1 and tst-ptrguard1-static pass. If they don't
>> pass please email me and we can work out what might be
>> wrong with your POINTER_CHK_GUARD implementation.
>
> New ptrguard tests fail on SH because the target uses generic
> stackguard-macros.h but defines THREAD_SET_POINTER_GUARD.
> The attached patch works for me.
>
> Regards,
> kaz
> --
> * sysdeps/sh/stackguard-macros.h: New file.
>
> diff --git a/sysdeps/sh/stackguard-macros.h b/sysdeps/sh/stackguard-macros.h
> new file mode 100644
> index 0000000..55a5771
> --- /dev/null
> +++ b/sysdeps/sh/stackguard-macros.h
> @@ -0,0 +1,6 @@
> +#include <stdint.h>
> +
> +extern uintptr_t __stack_chk_guard;
> +#define STACK_CHK_GUARD __stack_chk_guard
> +
> +#define POINTER_CHK_GUARD THREAD_GET_POINTER_GUARD()
>
Kaz,
That looks good to me. I will admit that's not a
combination I thought about. Thanks for fixing it.
Cheers,
Carlos.