This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
RE: [Patch] ARM define atomic_exchange_acq/atomic_exchange_rel to __atomic_exchange_n
- From: Abhishek Deb <adeb at nvidia dot com>
- To: Joseph Myers <joseph at codesourcery dot com>, Dinar Temirbulatov <dtemirbulatov at gmail dot com>
- Cc: "libc-ports at sourceware dot org" <libc-ports at sourceware dot org>, Maxim Kuvyrkov <maxim at kugelworks dot com>
- Date: Thu, 5 Sep 2013 10:09:41 -0700
- Subject: RE: [Patch] ARM define atomic_exchange_acq/atomic_exchange_rel to __atomic_exchange_n
- Authentication-results: sourceware.org; auth=none
- References: <CAMnfPmMADb=ZqSmC4J6=fMpQp56uGG8v9MKRj_Ly94kcXEtNZA at mail dot gmail dot com> <Pine dot LNX dot 4 dot 64 dot 1309021457010 dot 17654 at digraph dot polyomino dot org dot uk> <CAMnfPmOyoRNNu62uAvTPDfa42XCwBdrW0n5jAW0Ab+nPS8u86Q at mail dot gmail dot com> <Pine dot LNX dot 4 dot 64 dot 1309051542360 dot 28271 at digraph dot polyomino dot org dot uk>
Compilation with 4.8.0 succeeded, whereas compilation with 4.6.2 failed due to the trailing $ as pointed by Joseph.
Abhishek
-----Original Message-----
From: Joseph Myers [mailto:joseph@codesourcery.com]
Sent: Thursday, September 05, 2013 8:48 AM
To: Dinar Temirbulatov
Cc: libc-ports@sourceware.org; Abhishek Deb; Maxim Kuvyrkov
Subject: Re: [Patch] ARM define atomic_exchange_acq/atomic_exchange_rel to __atomic_exchange_n
On Thu, 5 Sep 2013, Dinar Temirbulatov wrote:
> Hi,
> Here is updated version of change. Ok to commit?
You appear to insert a '$' after '\' on one line - that can't be right.
Please try to test all three cases in the code.
Where you have "typeof(*mem)", there should be a space before the '('.
--
Joseph S. Myers
joseph@codesourcery.com