This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH, v5] ARM: Add Cortex-A15 optimized NEON and VFP memcpy routines, with IFUNC.
- From: Richard Henderson <rth at twiddle dot net>
- To: Will Newton <will dot newton at linaro dot org>
- Cc: libc-ports at sourceware dot org, patches at linaro dot org, Roland McGrath <roland at hack dot frob dot com>
- Date: Wed, 01 May 2013 13:52:59 +0100
- Subject: Re: [PATCH, v5] ARM: Add Cortex-A15 optimized NEON and VFP memcpy routines, with IFUNC.
- References: <517FF73E dot 5020509 at linaro dot org>
On 2013-04-30 17:54, Will Newton wrote:
+<http://www.gnu.org/licenses/>. */
+
+#define NO_THUMB
Please add a comment as to why NO_THUMB is being set. C.f. the other
uses of that macro within sysdeps/arm/. (It's the negative offsets
for memories as I recall, but that won't be obvious from this file.)
+ /* Jump directly into the sequence below at the correct offset. */
+ add pc, pc, tmp1, lsl #1
This is going to fail for NaCl, defining ARM_ALWAYS_BX. I'm not quite
sure all of what needs to be done to fix that. I'm sure Roland will
have some advice...
Perhaps the answer is "nothing" and NaCl should be vectored back to the
non-ifunc version of the code.
r~