This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH] Better distinguish between NaN/qNaN/sNaN.
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Andreas Jaeger <aj at suse dot com>
- Cc: Thomas Schwinge <thomas at codesourcery dot com>, libc-alpha at sourceware dot org, libc-ports at sourceware dot org, munroesj at us dot ibm dot com, rsa at us dot ibm dot com, joseph at codesourcery dot com
- Date: Tue, 05 Mar 2013 16:14:16 -0500
- Subject: Re: [PATCH] Better distinguish between NaN/qNaN/sNaN.
- References: <1362511911-26857-1-git-send-email-thomas@codesourcery.com> <51365EAF.80407@suse.com>
On 03/05/2013 04:07 PM, Andreas Jaeger wrote:
> On 03/05/2013 08:31 PM, Thomas Schwinge wrote:
>> In preparation for adding tests with sNaN inputs later on.
>>
>> * math/basic-test.c (TEST_FUNC, TEST_TRUNC): Rename NaN_var to
>> qNaN_var. Fix a few strings, too.
>> * math/libm-test.inc (nan_value): Rename to qnan_value.
>> * math/gen-libm-test.pl (%beautify): Adjust to that.
>> * math/bits/mathcalls.h (nan): Refer to qNaN instead of NaN.
>> * math/test-misc.c (main): Likewise.
>> * sysdeps/ieee754/bits/nan.h (__nan_bytes, __nan_union): Rename
>> to __qnan_bytes, and __qnan_union, respectively.
>> * ports/sysdeps/mips/bits/nan.h (__nan_bytes, __nan_union):
>> Likewise.
>> * stdio-common/tstdiomisc.c (nanval, lnanval): Rename to qnanval,
>> and lqnanval, respectively.
>> * sysdeps/powerpc/bits/fenv.h: Fix usage of NaN/qNaN/sNaN.
>> * sysdeps/powerpc/fpu/fenv_libc.h: Likewise.
>> * sysdeps/powerpc/fpu/test-powerpc-snan.c (TEST_FUNC): Likewise,
>> and rename NaN_var to qNaN_var, and SNaN_var to sNaN_var.
>
> this is fine,
Looks good to me also.
Cheers,
Carlos.