This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: Fix warnings from MIPS soft-float _FPU_GETCW
- From: Chris Metcalf <cmetcalf at tilera dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: <libc-ports at sourceware dot org>
- Date: Wed, 5 Dec 2012 10:15:08 -0500
- Subject: Re: Fix warnings from MIPS soft-float _FPU_GETCW
- References: <Pine.LNX.4.64.1212042207210.17916@digraph.polyomino.org.uk>
On 12/4/2012 5:07 PM, Joseph S. Myers wrote:
> Testing for MIPS soft-float showed up compile warnings ("statement
> with no effect") in setfpucw.c arising from the soft-float definition
> of _FPU_GETCW just being "0". I've applied this patch to make the
> definition actually store 0 in cw, and correspondingly to make
> _FPU_SETCW use cw by casting the value to (void), to make these
> soft-float definitions better at avoiding warnings from use using
> these macros.
>
> 2012-12-04 Joseph Myers <joseph@codesourcery.com>
>
> * sysdeps/mips/fpu_control.h [__mips_soft_float] (_FPU_GETCW):
> Define to set cw to 0, now just to plain "0" as a statement.
> [__mips_soft_float] (_FPU_SETCW): Define to (void) (cw), rather
> than doing nothing with cw.
I see the same warning on tile, because we are using sysdeps/generic/fpu_control.h, which has the same issue. Do you want to fix that file as well as the mips one while you're at it? Or should I push that same fix?
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com