This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: Convert ia64 to use <bits/fcntl-linux.h>


On 10/24/2012 10:28 PM, Mike Frysinger wrote:
On Wednesday 24 October 2012 15:08:46 Andreas Jaeger wrote:
[...]
  #define F_SETLK64	6	/* Set record locking info (non-blocking).  */
  #define F_SETLKW64	7	/* Set record locking info (blocking).	*/

for these three, i wonder if we could make bits/fcntl-linux.h smarter. like: #ifndef F_GETLK64 # if __O_LARGEFILE <current defines to 12/13/14> # else <new defines to the non-64bit versions> # endif #endif

we'd have to tweak the logic so F_GETLK also does:
#ifndef F_GETLK
# if !defined __USE_FILE_OFFSET64 && __O_LARGEFILE
<current defines to 5/6/7>
...

I looked closer at this:
This would work but it depends on the assumption that __O_LARGEFILE == 0 means we have a 64-bit port. This is getting to hairy IMHO, thus I'm not going to do it.


Andreas
--
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]