This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [patch, mips] Fix stubs files for hard float vs. soft float
On Thu, 2012-10-25 at 12:41 +0000, Joseph S. Myers wrote:
> On Wed, 24 Oct 2012, Steve Ellcey wrote:
>
> > +# Get value of abi-default
> > +#include $(common-objpfx)default-abi.make
>
> Is this really tested for all ABI variants? Having this commented out
> hardly makes sense....
>
> > +#ifeq (,$(filter $(default-abi),$(abi-variants)))
> > +#Unknown ABI, must be one of $(abi-variants)
> > +#endif
>
> Don't add new commented-out code.
Neither of these (the include or the ifeq) should have been commented
out, that is a remnant of my development work. I checked to make sure
that default-abi.make was getting created and had the right value but I
didn't check the actual stub files to make sure they looked right (they
aren't). The build did work even with these commented out. I will
uncomment these lines, rebuild, do more testing, and resubmit.
Steve Ellcey
sellcey@mips.com
- References:
- [patch, mips] Fix stubs files for hard float vs. soft float
- Re: [patch, mips] Fix stubs files for hard float vs. soft float
- Re: [patch, mips] Fix stubs files for hard float vs. soft float
- Re: [patch, mips] Fix stubs files for hard float vs. soft float
- Re: [patch, mips] Fix stubs files for hard float vs. soft float
- Re: [patch, mips] Fix stubs files for hard float vs. soft float
- Re: [patch, mips] Fix stubs files for hard float vs. soft float
- Re: [patch, mips] Fix stubs files for hard float vs. soft float
- Re: [patch, mips] Fix stubs files for hard float vs. soft float
- Re: [patch, mips] Fix stubs files for hard float vs. soft float
- Re: [patch, mips] Fix stubs files for hard float vs. soft float
- Re: [patch, mips] Fix stubs files for hard float vs. soft float
- Re: [patch, mips] Fix stubs files for hard float vs. soft float
- Re: [patch, mips] Fix stubs files for hard float vs. soft float
- Re: [patch, mips] Fix stubs files for hard float vs. soft float
- Re: [patch, mips] Fix stubs files for hard float vs. soft float