This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: Fix O_LARGEFILE for Linux/SPARC and s390 (was: Re: [PATCH] ARM: Use <bits/fcntl-linux.h> )
On Mon, 22 Oct 2012, Andreas Jaeger wrote:
> #ifdef __USE_LARGEFILE64
> # if __WORDSIZE == 64
> /* Not necessary, files are always with 64bit off_t. */
> -# define O_LARGEFILE 0
> +# define __O_LARGEFILE 0
> # else
> -# define O_LARGEFILE 0100000
> +# define __O_LARGEFILE 0100000
> # endif
> #endif
I think it's more consistent not to have the __USE_LARGEFILE64
conditionals here: to define the __O_* macro unconditionally (like other
__O_* macros) and have the conditional only in fcntl-linux.h on the
O_LARGEFILE definition.
--
Joseph S. Myers
joseph@codesourcery.com