This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH] Get rid of ASM_SIZE_DIRECTIVE
On Mon, Sep 17, 2012 at 12:25:08PM -0700, Roland McGrath wrote:
> Having helper macros that we use in our code is certainly fine, and
> appropriate when code using the macros is more concise, easier to maintain,
> etc. That's a separate issue from de-conditionalizing things.
>
> ASM_SIZE_DIRECTIVE is a useful macro, though it has a very poor choice of
> name. The macro looks like it should expand just to ".size", like the
> ASM_GLOBAL_DIRECTIVE expanded just to ".globl". We don't need a macro for
> that. A shorthand macro is most useful when it has a short name.
So, what about renaming it to ASM_SIZE, remove definitions in sysdep.h
headers and moving the definion of ASM_SIZE into say libc-symbols.h?
Marek