This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH] Get rid of ASM_TYPE_DIRECTIVE{,_PREFIX}
- From: Marek Polacek <polacek at redhat dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: libc-alpha at sourceware dot org, libc-ports <libc-ports at sourceware dot org>, Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>, Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>, David Miller <davem at davemloft dot net>
- Date: Sat, 28 Jul 2012 00:11:45 +0200
- Subject: Re: [PATCH] Get rid of ASM_TYPE_DIRECTIVE{,_PREFIX}
- References: <20120727191849.GJ3311@redhat.com> <20120727202833.25E832C109@topped-with-meat.com>
On Fri, Jul 27, 2012 at 01:28:33PM -0700, Roland McGrath wrote:
> I only skimmed but this all looks fine to me. For paranoia's sake, since
> this should not change anything, please check that no code changed for i?86
> and x86_64 (eu-elfcmp might suffice, or else objdump -d comparisons).
> It should still wait for at least two of sh, powerpc, s390 to report
> testing ok. But since this is so mechanical and simple, I'd say if they
> are slow (like past the middle of next week, say), commit it anyway and
> just remind folks they still need to test.
Ok. Looks like no code changed for both i?86 and x86_64:
marek@pdp-11 ~/libc-build $ eu-elfcmp -l libc.so.new libc.so
eu-elfcmp: libc.so.new libc.so differ: build ID content
marek@pdp-11 ~/libc-build $ eu-elfcmp -l ld.so.new elf/ld.so
eu-elfcmp: ld.so.new elf/ld.so differ: build ID content
Thanks for review,
Marek