This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Breaking ARM's mcount implementations into a separate file


Hello!

On 2009-12-15 02:05, Joseph S. Myers wrote:
> On Tue, 15 Dec 2009, Thomas Schwinge wrote:
>> I inspected the pre / post libraries (symbols, disassembly), and did test
>> runs to confirm that profiling still works in the ``normal'' and -mthumb
>> cases.
>
> I'm not sure of the significance of having separate ARM/Thumb versions, 

Well, if I understand this correctly, it was you, together with Paul
Brook, who have added this code on 2009-02-05.

> but it does not make much sense to me to have different __thumb2__ 
> versions that still get compiled in ARM mode when glibc is built as 
> Thumb-2.  Remember that .S files get built in ARM mode unless they contain 
> assembler directives to use Thumb, but __thumb2__ is defined if the 
> compiler would generate Thumb-2.  If you want particular .S sources built 
> as Thumb-2 code, you need something like sysdeps/arm/elf/start.S:
>
> #if defined(__thumb2__)
>         .thumb
>         .syntax unified
> #endif

This is correct.  I transformed the code without thinking about that.  Do
I need to resend the patch, or can the one who is comitting it easily add
the two assembler directives to the [__thumb2__] code?


Regards,
 Thomas

Attachment: pgp00000.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]