This is the mail archive of the
libc-ports@sources.redhat.com
mailing list for the libc-ports project.
Re: [PATCH] Fix mmap2 syscall for ColdFire
Daniel Jacobowitz <drow@false.org> writes:
> On Fri, Oct 02, 2009 at 02:16:25PM +0200, Andreas Schwab wrote:
>> Maxim Kuvyrkov <maxim@codesourcery.com> writes:
>>
>> > Andreas Schwab wrote:
>> >> Maxim Kuvyrkov <maxim@codesourcery.com> writes:
>> >>
>> >>> M68K linux port expects the argument of mmap2 syscall to be counted in
>> >>> the memory pages.
>> >>
>> >> The offset is supposed to be always counted in units of 4k.
>> >
>> > Unfortunately, that is not the case for ColdFire.
>>
>> Which is a kernel bug.
>
> It's a long-standing kernel ABI wart. I disagree that it's a bug, and
> it would be a royal pain to have kernels with two different shift
> amounts!
Ok. But hardcoding it is wrong, that's what getpagesize is for.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."