This is the mail archive of the libc-ports@sources.redhat.com mailing list for the libc-ports project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Duplicate ustat structure


On dim, 2006-07-16 at 16:13 -0400, Carlos O'Donell wrote:
> On 7/16/06, Jeff Bailey <jbailey@raspberryginger.com> wrote:
> > On Sun, Jul 16, 2006 at 06:39:15PM +0200, Andreas Schwab wrote:
> >
> > > > The problem is that bits/ustat.h includes the definition of struct
> > > > ustat.  However, sys/types.h eventually winds up pulling in
> > > > linux/types.h which also defines struct ustat.
> > >
> > > <sys/types.h> should not include <linux/types.h> in the first place.
> >
> > It seems like it ought to now that the kernel is exporting a set of
> > headers that are intended to be used by userspace.  struct ustat is
> > defined in linux/types.h.
> 
> In which case this patch should go upstream to libc-alpha, where the
> generic version of ustat.h should be changed.

Certainly, but could you apply the second patch in the meantime?  That's
what all the other arch's do right now, and it will at least make
current glibc buildable with current kernel headers.  I'll try and pitch
the concept of using kernel headers instead of copying values into glibc
when I have enough time and energy to fight that battle.

Tks,
Jeff Bailey

-- 
Although when you're in the situation that RMS is telling you that
you're being too ideological about freedom, maybe, just maybe, it's
true.
- Matthew Wilcox


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]