[Bug localedata/23208] New locale - Lower Sorbian (dsb)

["digitalfreak at lingonborough dot com" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=23208

Rafal Luzynski <digitalfreak at lingonborough dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |digitalfreak@lingonborough.
                   |                            |com

--- Comment #1 from Rafal Luzynski <digitalfreak at lingonborough dot com> ---
Thank you, Michael.  Here is my review:

First, some nitpicks:

1. It would be better to attach a patch rather than a file.
2. The patch should add this line: "dsb_DE.UTF-8/UTF-8 \" to
localedata/SUPPORTED.
3. The file should not have a ".txt" suffix and should have Unix (LF) rather
than Windows (CRLF) line ends.
4. There should be no line numbers.

I have fixed it all locally.

> LC_IDENTIFICATION
> title      "Lower Sorbian locale for Germany"
> source     "Information from Michael Wolf"
> address    ""
> contact    ""
> email      ""
> tel        ""
> fax        ""

It's not obligatory but wouldn't you like to add your personal data here? If
not, then maybe let's add "bug-glibc-locales@gnu.org" as the email?

> LC_COLLATE
> copy "iso14651_t1"
> 
> % CLDR collation rules for Lower Sorbian:
> % (see:https://unicode.org/cldr/trac/browser/trunk/common/collation/dsb.xml)
> %
> [...]

Mike is an expert at collation so I leave it to him.

Does Lower Sorbian use exactly the same alphabet and collation rules as Upper
Sorbian?  If yes then maybe “copy "hsb_DE"” would be sufficient?

> LC_CTYPE
> copy "i18n"
> END LC_CTYPE

I'm not sure.  I have a feeling that something is missing here.  But if we
don't figure out let's leave it as is.

> LC_MESSAGES
> yesexpr "^[+1hHyY]"
> noexpr  "^[-0nN]"
> yesstr  "jo"
> nostr   "n<U011B>"
> END LC_MESSAGES

If "yes" is "jo" in DSB then "yesexpr" must contain "jJ".  Also as it has been
copied from HSB I think that HSB should include "jJ" for the compatibility with
German.  Whether DSB should include "hH" for the compatibility with HSB...
well, it's a question to you if there are DSB computer users so used to HSB
that they may press 'H' as the answer for "yes"?

> LC_MONETARY
> copy "de_DE"
> END LC_MONETARY
> 
> LC_NUMERIC
> copy "de_DE"
> END LC_NUMERIC

Good, copy from "de_DE" whatever is common.

> LC_TIME
> abday   "Nj";"P<U00F3>";/
>         "Wa";"Sr";/
>         "St";"P<U011B>";/
>         "So"
> day     "Nje<U017A>ela";/
>         "P<U00F3>n<U017A>ela";/

This says: "Pónźela" - CLDR says "pónjeźele".

>         "Wa<U0142>tora";/
>         "Srjoda";/
>         "Stw<U00F3>rtk";/
>         "P<U011B>tk";/
>         "Sobota"

Do you want to start all weekday names with uppercase? According to CLDR it is
not necessary but if you think that weekday names usually appear in the
beginning of the sentence and therefore you want to leave it like this then it
is OK.

> abmon   "Jan";"Feb";/
>         "M<U011B>r";"Apr";/
>         "Maj";"Jun";/
>         "Jul";"Awg";/
>         "Sep";"Okt";/
>         "Now";"Dec"
> alt_mon     "Januar";/
>         "Februar";/
>         "M<U011B>rc";/
>         "Apryl";/
>         "Maj";/
>         "Junij";/
>         "Julij";/
>         "Awgust";/
>         "September";/
>         "Oktober";/
>         "Nowember";/
>         "December"

Again, there is no reason to start the month names with the uppercase unless
you think it is good because they will usually appear in the beginning of a
sentence (including standalone).

> mon  "januara";/
>         "februara";/
>         "m<U011B>rca";/
>         "apryla";/
>         "maja";/
>         "junija";/
>         "julija";/
>         "awgusta";/
>         "septembra";/
>         "oktobra";/
>         "nowembra";/
>         "decembra"
> d_t_fmt "%a %d %b %Y %T %Z"
> d_fmt   "%d.%m.%Y"
> t_fmt   "%T"
> am_pm   "";""
> t_fmt_ampm ""
> 
> week    7;19971130;4
> first_weekday 2
> END LC_TIME

Otherwise looks good.

> LC_PAPER
> copy "de_DE"
> END LC_PAPER

Most of the locales use either “copy "i18n"” or “copy "en_US"”.

> LC_TELEPHONE
> copy "de_DE"
> END LC_TELEPHONE
> 
> LC_MEASUREMENT
> copy "de_DE"
> END LC_MEASUREMENT

Again good, copy from "de_DE" whatever is common.

> LC_NAME
> name_fmt    "%d%t%g%t%m%t%f"
> name_miss   "kn<U011B><U017E>na"
> name_mr     "kn<U011B>z"
> name_mrs    "kn<U011B>ni"
> %name_ms     ""
> END LC_NAME

What about:

name_ms     "kn<U011B>ni"

> LC_ADDRESS
> postal_fmt    "%f%N%a%N%d%N%b%N%s %h %e %r%N%z %T%N%c%N"
> country_name  "Nimska"
> country_post  "D"
> country_ab2   "DE"
> country_ab3   "DEU"
> country_num   276
> country_car   "D"
> country_isbn  3
> lang_name     "dolnoserb<U0161><U0107>ina"
> lang_ab      ""
> lang_term    "dsb"
> lang_lib     "dsb"
> END LC_ADDRESS

I can see this is copied from hsb_DE except few fields which had obligatorily
to be changed.  Therefore I believe this is correct.

Again, thank you Michael.

-- 
You are receiving this mail because:
You are on the CC list for the bug.