This is the mail archive of the libc-locales@sourceware.org mailing list for the GNU libc locales project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][BZ 18934] hu_HU: Fix multiple sorting bugs.


On 02/09/2017 05:19 PM, Egmont Koblinger wrote:
> Carlos, any news?
> 
> Did Luis's and my comment help you move forward?
> 
> I'd like to emphasize again that my patch does not do anythinig
> serious. No big redesign, no fundamental change, nothing like this.
> The things Luis mentioned were either already implemented that way, or
> I did not touch them. It's just a few, technically small bugfixes that
> I made. Really nothing big deal. Plus unittests.
> 
> I have, a long time ago, offered that I can turn this all-in-one patch
> into like 4-5 patches to be applied on top of each other. But then
> they'd have to be reviewed and applied in a particular order (because
> they'd heavily conflict) at once. I know that generally this is the
> preferred approach, however, it cannot work together with test driven
> development since there's no way to test the intermediate (i.e.
> deliberately still broken) states. Having chosen TDD, the result of my
> work was a patch that fixes all the referred bugs in a single step. I
> can, I still offer to spend some more time on it to create a few
> smaller, easier to review patches *if* seriously that is what's
> missing from getting my work accepted. Let me know.

I think your patch is ready to go, but we need a senior person with
commit privileges to review and check it in.

Please ping me again next week on Wednesday and I'll arrange to try
test and checkin on Thursday.

-- 
Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]