This is the mail archive of the libc-locales@sourceware.org mailing list for the GNU libc locales project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug localedata/19963] en_IL: New locale


https://sourceware.org/bugzilla/show_bug.cgi?id=19963

--- Comment #3 from Guy <guyrutenberg at gmail dot com> ---
Thanks for your feedback Mike. I've made most of the changes you suggested (I
wasn't sure about a couple of them, see below) and uploaded a new updated
version ('en_IL').

>>escape_char /
>>comment_char %
>>% Locale for English locale in Israel
>>% Contributed by Guy Rutenberg <guyrutenberg@gmail.com>, 2016
>
>please use the same top content as the other locales.  look at the first 10 lines of he_IL.

I've changed those lines. I've originally copied the beginning of en_US, so I
thought that was the right header.

>>title      "English locale for Israel"
>
>use:
>English language locale for Israel

Fixed.

>>category  "en_IL:2016";LC_IDENTIFICATION
>>category  "en_IL:2016";LC_CTYPE
>>category  "en_IL:2016";LC_COLLATE
>>category  "en_IL:2016";LC_TIME
>>category  "en_IL:2016";LC_NUMERIC
>>category  "en_IL:2016";LC_MONETARY
>>category  "en_IL:2016";LC_MESSAGES
>>category  "en_IL:2016";LC_PAPER
>>category  "en_IL:2016";LC_NAME
>>category  "en_IL:2016";LC_ADDRESS
>>category  "en_IL:2016";LC_TELEPHONE
>>category  "en_IL:2016";LC_MEASUREMENT
>
>these should all be i18n:2012 instead

Are you sure? According to the man page this should be "a string that
identifies this locale category definition". I've looked at couple of other
locales (he_IL, en_GB, en_US, en_NZ, en_AG) and all use the locale name and the
year it was introduced.

>>LC_COLLATE
>>% Copy the template from ISO/IEC 14651
>>copy "iso14651_t1"
>>END LC_COLLATE
>
>just copy en_GB instead

Done.

>>%
>>% Appropriate date and time representation (%c)
>>%	"%a %d %b %Y %T %Z"
>
>drop all these inline comments in LC_TIME & LC_ADDRESS
Done.

>>week    7;19971130;4
>
>pretty sure this should be:
>week 7;19971130;1
The '4' is the minimal length of the first week of the year. Having '4' (which
is the default), ensures that given a week that spans two years, it will be
counted in the year that has most of it.

>>>first_weekday	1
>>
>>this is the default, so drop it.
>
>>LC_PAPER
>>copy "en_GB"
>>END LC_PAPER
>
>copy he_IL instead.  this is a regional trait rather than language.

Done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]