This is the mail archive of the
libc-help@sourceware.org
mailing list for the glibc project.
Re: [Patch] RFE new API - gettimezone
- From: P J P <pj dot pandit at yahoo dot co dot in>
- To: "libc-help at sourceware dot org" <libc-help at sourceware dot org>
- Date: Wed, 2 Apr 2014 22:17:33 +0800 (SGT)
- Subject: Re: [Patch] RFE new API - gettimezone
- Authentication-results: sourceware.org; auth=none
- References: <1396378055 dot 16229 dot YahooMailNeo at web192405 dot mail dot sg3 dot yahoo dot com> <1396444446 dot 15012 dot YahooMailNeo at web192402 dot mail dot sg3 dot yahoo dot com> <CAAHN_R14hWjwAGgzF=tzJ9_w+Ao16tp054aE-7P+3AgQmLVLmg at mail dot gmail dot com>
- Reply-to: P J P <pj dot pandit at yahoo dot co dot in>
Hello Siddhesh,
> On Wednesday, 2 April 2014 7:29 PM, Siddhesh Poyarekar wrote:
> Patches go to libc-alpha at sourceware dot org, this mailing list is
> for general questions. You might want to take a look at the
> contribution checklist:
>
> http://sourceware.org/glibc/wiki/Contribution%20checklist
I see, thanks so much for the link. I'll go through it.
> Also, you might want to post the patch inline rather than as an
> attachment since it makes reviews easier.
Right, got it.
> There are several other changes you'll need to change to get there, like:
> - Avoid using the hardcoded strings and use those defined in glibc instead
I guess timezone/tzfile.h should help with that?
> - Modifying time/Makefile to get gettimezone to build.
> - Adding a symbol to time/Versions to export a symbol for gettimezone.
I did modify the time/Makefile to build it locally, but could not get the Makefile to run, for an error:
$ make
Makeconfig:42: *** missing separator. Stop.
Thank you.
---
Regards
-Prasad