This is the mail archive of the
libc-help@sourceware.org
mailing list for the glibc project.
Need help in properly formatting a patch for glibc
- From: Denys Vlasenko <dvlasenk at redhat dot com>
- To: libc-help at sourceware dot org
- Date: Mon, 18 Aug 2008 17:32:17 +0200
- Subject: Need help in properly formatting a patch for glibc
Hi!
I've sent the following email to libc-alpha:
============================================
Even though I failed to reproduce it, the patch looks obviously correct.
The reporter tested it and he says that this patch fixes the problem.
Details are at https://bugzilla.redhat.com/show_bug.cgi?id=457508
Please apply.
for Changelog:
2008-18-08 Denys Vlasenko <dvlasenk@redhat.com>
* libc/malloc/malloc.c: fix a case of realloc not copying entire block
--
vda
============================================
I got the following reply:
============================================
Hi! This is the ezmlm program. I'm managing the
libc-alpha@sourceware.org mailing list.
I'm sorry, your message (enclosed) was not accepted by the moderator.
If the moderator has made any comments, they are shown below.
>>>>> -------------------- >>>>>
Hi,
Your GNU ChangeLog format is incorrect, and that makes your patch
unacceptable on libc-alpha.
Please resend this email to the libc-help mailing list where other
developers can help you work on your patch until it meets community
standards.
Regards,
Carlos O'Donell
libc-alpha moderation staff
<<<<< -------------------- <<<<<
===============================================
Please advice what I did wrong, and what is the correct Changelog
format.
--
vda
--- Begin Message ---
- From: Denys Vlasenko <dvlasenk at redhat dot com>
- To: libc-alpha at sources dot redhat dot com
- Date: Mon, 18 Aug 2008 17:10:34 +0200
- Subject: [PATCH] fix a case of realloc not copying entire block (RH bug457508)
Even though I failed to reproduce it, the patch looks obviously correct.
The reporter tested it and he says that this patch fixes the problem.
Details are at https://bugzilla.redhat.com/show_bug.cgi?id=457508
Please apply.
for Changelog:
2008-18-08 Denys Vlasenko <dvlasenk@redhat.com>
* libc/malloc/malloc.c: fix a case of realloc not copying entire block
--
vda
--- libc/malloc/malloc.c 2008-03-04 19:36:04.000000000 +0100
+++ libc/malloc/malloc.c 2008-08-14 18:43:22.000000000 +0200
@@ -3717,7 +3717,7 @@ public_rEALLOc(Void_t* oldmem, size_t by
newp = public_mALLOc(bytes);
if (newp != NULL)
{
- MALLOC_COPY (newp, oldmem, oldsize - 2 * SIZE_SZ);
+ MALLOC_COPY (newp, oldmem, oldsize - SIZE_SZ);
#if THREAD_STATS
if(!mutex_trylock(&ar_ptr->mutex))
++(ar_ptr->stat_lock_direct);
--- End Message ---