This is the mail archive of the libc-hacker@sourceware.org mailing list for the glibc project.
Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Hi! See https://bugzilla.redhat.com/show_bug.cgi?id=381411 g++ 4.1 and 4.2 -Wstrict-aliasing warnings is sometimes more verbose than it should, struct __jmp_buf_tag has just forward decl and so g++ decides to warn just in case. The extra cast shuts this up and doesn't harm the code (for obscure compilation mode which should never be really used with pthread_cancel and the cleanup macros anyway). 2007-11-20 Jakub Jelinek <jakub@redhat.com> * sysdeps/pthread/pthread.h (pthread_cleanup_push, pthread_cleanup_push_defer_np): Add extra (void *) cast to shut up g++ 4.1 and 4.2 -Wstrict-aliasing warnings. --- libc/nptl/sysdeps/pthread/pthread.h.jj 2007-06-04 08:42:06.000000000 +0200 +++ libc/nptl/sysdeps/pthread/pthread.h 2007-11-20 23:28:21.000000000 +0100 @@ -638,7 +638,7 @@ __pthread_cleanup_routine (struct __pthr __pthread_unwind_buf_t __cancel_buf; \ void (*__cancel_routine) (void *) = (routine); \ void *__cancel_arg = (arg); \ - int not_first_call = __sigsetjmp ((struct __jmp_buf_tag *) \ + int not_first_call = __sigsetjmp ((struct __jmp_buf_tag *) (void *) \ __cancel_buf.__cancel_jmp_buf, 0); \ if (__builtin_expect (not_first_call, 0)) \ { \ @@ -672,7 +672,7 @@ extern void __pthread_unregister_cancel __pthread_unwind_buf_t __cancel_buf; \ void (*__cancel_routine) (void *) = (routine); \ void *__cancel_arg = (arg); \ - int not_first_call = __sigsetjmp ((struct __jmp_buf_tag *) \ + int not_first_call = __sigsetjmp ((struct __jmp_buf_tag *) (void *) \ __cancel_buf.__cancel_jmp_buf, 0); \ if (__builtin_expect (not_first_call, 0)) \ { \ Jakub
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |