This is the mail archive of the libc-hacker@sourceware.org mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH] map_v4v6_address

From: Jakub Jelinek <jakub at redhat dot com>
To: Ulrich Drepper <drepper at redhat dot com>
Cc: Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: Tue, 21 Nov 2006 13:18:15 +0100
Subject: [PATCH] map_v4v6_address
Reply-to: Jakub Jelinek <jakub at redhat dot com>

Hi!

src is const char * (and furthermore not necessarily equal to dst).
I wonder if you don't want to copy to dst + 12 (or p + 12, which is
the same thing) instead.

2006-10-21  Jakub Jelinek  <jakub@redhat.com>

	* resolv/mapv4v6addr.h (map_v4v6_address): Fix last change.

--- libc/resolv/mapv4v6addr.h.jj	2006-11-21 13:08:02.000000000 +0100
+++ libc/resolv/mapv4v6addr.h	2006-11-21 13:10:02.000000000 +0100
@@ -59,7 +59,7 @@ map_v4v6_address (const char *src, char 
   int i;
 
   /* Move the IPv4 part to the right position.  */
-  memcpy (src + 12, src, INADDRSZ);
+  memcpy (dst + 12, src, INADDRSZ);
 
   /* Mark this ipv6 addr as a mapped ipv4. */
   for (i = 0; i < 10; i++)

	Jakub

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]