This is the mail archive of the libc-hacker@sourceware.org mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH] Fix i386 sysconf at -O3

From: Jakub Jelinek <jakub at redhat dot com>
To: Ulrich Drepper <drepper at redhat dot com>
Cc: Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: Fri, 10 Nov 2006 00:29:47 +0100
Subject: [PATCH] Fix i386 sysconf at -O3
Reply-to: Jakub Jelinek <jakub at redhat dot com>

Hi!

At least with GCC 4.1.x and -O3 the register pressure on i?86 is too
high with all the inline asm for cpuid.
The following patch cures it and is IMHO desirable anyway, intel_check_word
is quite big and it is wasteful to replicate it 3 times.

2006-11-10  Jakub Jelinek  <jakub@redhat.com>

	* sysdeps/unix/sysv/linux/i386/sysconf.c (intel_check_word): Add
	noinline attribute.

--- libc/sysdeps/unix/sysv/linux/i386/sysconf.c	2006-11-09 23:07:15.000000000 +0100
+++ libc/sysdeps/unix/sysv/linux/i386/sysconf.c	2006-11-09 23:07:15.000000000 +0100
@@ -139,7 +139,7 @@ intel_02_known_compare (const void *p1, 
 }
 
 
-static long int
+static long int  __attribute__ ((noinline))
 intel_check_word (int name, unsigned int value, bool *has_level_2,
 		  bool *no_level_2_or_3)
 {

	Jakub

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]