This is the mail archive of the libc-hacker@sourceware.org mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] PPC32 cfi update part3

From: Andreas Schwab <schwab at suse dot de>
To: Steven Munroe <munroesj at us dot ibm dot com>
Cc: libc-hacker at sources dot redhat dot com,Alan Modra <amodra at bigpond dot net dot au>
Date: Sun, 13 Aug 2006 10:15:03 +0200
Subject: Re: [PATCH] PPC32 cfi update part3
References: <43BC618A.1000006@us.ibm.com>

Steven Munroe <munroesj@us.ibm.com> writes:

> 	* sysdeps/powerpc/powerpc32/dl-trampoline.S (_dl_runtime_resolve,
> 	_dl_profile_resolve): Add CFI directives for stack and LR save.
> 	Save LR in LRSAVE of previous frame per ABI.

This breaks profiling.  The caller of _mcount is supposed to store LR in
LRSAVE, and _mcount restores it from there, but LRSAVE gets clobbered by
the trampoline.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Follow-Ups:
- Re: [PATCH] PPC32 cfi update part3
  - From: Andreas Schwab

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]