This is the mail archive of the libc-hacker@sourceware.org mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Symbol redefinition bugs

The current binutils revealed some symbol redefinition bugs in the
ppc/ppc64 port.

Andreas.

2005-11-18  Andreas Schwab  <schwab@suse.de>

	* sysdeps/powerpc/powerpc32/fpu/s_lround.S: Remove useless alias.

	* sysdeps/unix/sysv/linux/powerpc/powerpc32/socket.S: Handle
	NO_WEAK_ALIAS.
	* sysdeps/unix/sysv/linux/powerpc/powerpc64/socket.S: Likewise.

--- libc/sysdeps/powerpc/powerpc32/fpu/s_lround.S.~1.4.~	2005-06-20 11:05:09.000000000 +0200
+++ libc/sysdeps/powerpc/powerpc32/fpu/s_lround.S	2005-11-18 19:24:09.000000000 +0100
@@ -79,7 +79,6 @@ ENTRY (__lround)
 	b	.L9
 	END (__lround)
 
-strong_alias (__lround, __lround)
 weak_alias (__lround, lround)
 
 strong_alias (__lround, __lroundf)
--- libc/sysdeps/unix/sysv/linux/powerpc/powerpc32/socket.S.~1.4.~	2005-06-20 11:05:20.000000000 +0200
+++ libc/sysdeps/unix/sysv/linux/powerpc/powerpc32/socket.S	2005-11-18 18:25:51.000000000 +0100
@@ -44,7 +44,11 @@
 #define stackblock 20
 
 #ifndef __socket
-#define __socket P(__,socket)
+# ifndef NO_WEAK_ALIAS
+#  define __socket P(__,socket)
+# else
+#  define __socket socket
+# endif
 #endif
 
 	.text
@@ -114,4 +118,6 @@ ENTRY(__socket)
 
 PSEUDO_END (__socket)
 
+#ifndef NO_WEAK_ALIAS
 weak_alias (__socket, socket)
+#endif
--- libc/sysdeps/unix/sysv/linux/powerpc/powerpc64/socket.S.~1.5.~	2005-01-10 10:41:04.000000000 +0100
+++ libc/sysdeps/unix/sysv/linux/powerpc/powerpc64/socket.S	2005-11-18 19:10:23.000000000 +0100
@@ -41,12 +41,12 @@
 
 #define stackblock 80 /* offset to socket parm area.  */
 
-#ifndef socket
-/* If this is just socket.S leave it alone! */
-#else
 #ifndef __socket
-#define __socket P(__,socket)
-#endif
+# ifndef NO_WEAK_ALIAS
+#  define __socket P(__,socket)
+# else
+#  define __socket socket
+# endif
 #endif
 
 	.text
@@ -120,4 +120,6 @@ ENTRY(__socket)
 	cfi_endproc
 PSEUDO_END (__socket)
 
+#ifndef NO_WEAK_ALIAS
 weak_alias (__socket, socket)
+#endif

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]