This is the mail archive of the libc-hacker@sourceware.org mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Bugs in sysdeps/ia64/fpu/libm_error.c


On Sun, Aug 14, 2005 at 09:19:34PM +0200, Jakub Jelinek wrote:
> Hi!
> 
> sysdeps/ia64/fpu/libm_error.c has 3 huge switches that handle various
> conditions.  For
> else if(_LIB_VERSIONIMF==_ISOC_)
> and
> else if(_LIB_VERSIONIMF==_POSIX_)
> it has an abort () in default: case, while in
> /* __SVID__ and __XOPEN__ Path */
> switch it does not and has a comment that it doesn't indeed cover all
> the cases.
> Now, looking just at the differences between the first 2 switches,
> values handled by _ISOC_ switch but not _POSIX_ switch are:

I talked to Intel libm people. They suggested removing abort.


H.J.
----
2005-08-19  H.J. Lu  <hongjiu.lu@intel.com>

	* sysdeps/ia64/fpu/libm_error.c (__libm_error_support): Don't
	abort.

--- sysdeps/ia64/fpu/libm_error.c.abort	2005-04-08 10:24:55.000000000 -0700
+++ sysdeps/ia64/fpu/libm_error.c	2005-08-19 16:37:10.434656746 -0700
@@ -674,7 +674,7 @@ else if(_LIB_VERSIONIMF==_ISOC_)
          ERRNO_DOMAIN; break;
     }
     default:
-      abort();
+      break;
    }
    return;
 }
@@ -1374,7 +1374,7 @@ switch(input_tag)
       ERRNO_RANGE; break;
    }
   default:
-    abort();
+    break;
 }
 return;
 /* _POSIX_ */


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]