This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH] Remove nonnull from realpath

From: Jakub Jelinek <jakub at redhat dot com>
To: Ulrich Drepper <drepper at redhat dot com>, Roland McGrath <roland at redhat dot com>
Cc: Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: Wed, 1 Dec 2004 11:47:59 +0100
Subject: [PATCH] Remove nonnull from realpath
Reply-to: Jakub Jelinek <jakub at redhat dot com>

Hi!

http://www.opengroup.org/onlinepubs/009695399/functions/realpath.html
says that realpath (NULL, something) should NULL and set errno to
EINVAL.  Therefore calling this function with NULL argument is not
undefined behaviour and nonnull attribute is not appropriate.
test-canon.c: In function `do_test':
test-canon.c:128: warning: null argument where non-null required (arg 1)

2004-12-01  Jakub Jelinek  <jakub@redhat.com>

	* stdlib/stdlib.h (realpath): Remove nonnull attribute.

--- libc/stdlib/stdlib.h.jj	2004-11-26 10:16:32.000000000 +0100
+++ libc/stdlib/stdlib.h	2004-12-01 11:44:12.721671011 +0100
@@ -747,7 +747,7 @@ extern char *canonicalize_file_name (__c
    ENAMETOOLONG; if the name fits in fewer than PATH_MAX chars, returns the
    name in RESOLVED.  */
 extern char *realpath (__const char *__restrict __name,
-		       char *__restrict __resolved) __THROW __nonnull ((1));
+		       char *__restrict __resolved) __THROW;
 #endif
 
 

	Jakub

Follow-Ups:
- Re: [PATCH] Remove nonnull from realpath
  - From: Roland McGrath

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]