This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH] Fix setuid

From: Jakub Jelinek <jakub at redhat dot com>
To: Ulrich Drepper <drepper at redhat dot com>
Cc: Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: Sat, 25 Sep 2004 02:06:20 +0200
Subject: [PATCH] Fix setuid
Reply-to: Jakub Jelinek <jakub at redhat dot com>

Hi!

If __ASSUME_32BITUIDS == 0, but __NR_setuid32 is defined (e.g. when
configuring --enable-kernel=2.2.5 glibc with recent (where recent is not 7
years old) kernel headers), setuid will return failure even when it
succeeds.
The problem is there are two int result; decls, one at function's scope,
one in the if (__libc_missing_32bit_uids <= 0) block.

2004-09-25  Jakub Jelinek  <jakub@redhat.com>

	* sysdeps/unix/sysv/linux/i386/setuid.c (__setuid): Remove second
	result declaration.

--- libc/sysdeps/unix/sysv/linux/i386/setuid.c.jj	2004-09-20 15:35:10.000000000 +0200
+++ libc/sysdeps/unix/sysv/linux/i386/setuid.c	2004-09-25 02:01:05.334225542 +0200
@@ -47,7 +47,6 @@ __setuid (uid_t uid)
 # ifdef __NR_setuid32
   if (__libc_missing_32bit_uids <= 0)
     {
-      int result;
       int saved_errno = errno;
 
       result = INLINE_SYSCALL (setuid32, 1, uid);


	Jakub

Follow-Ups:
- Re: [PATCH] Fix setuid
  - From: Ulrich Drepper

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]