This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] SH: Add correct cleanup support and unwind info


> The attached patch updates mainly SH portion of nptl so to use
> unwind informations.  Almost changes are corresponding to those
> for i386.  This patch also tidies up a few kernel-feature stuff
> for the newer SH kernel.
> 
> With this patch, test-cancel[x]4, 5, 17, 19 and tst-tls3, 6 failed
> though they are not regressions because they failed without this
> patch.

The failures on tst-cancel[x]4, 5 and tst-cancel19 are caused
by a silly bug in cancellable syscall macros for SH.  My bad.

With the patch below, they passed.  It turned out that tst-tls3
doesn't fail when it is compiled with -O1 and it's an SH specific
gcc-3.4 problem.  So now only tst-cancel[x]17 and tst-tls6 fail
for unknown reason in nptl tests.

Regards,
	kaz
--
[nptl]
2004-03-20  Kaz Kojima  <kkojima@rr.iij4u.or.jp>

	* sysdeps/unix/sysv/linux/sh/sysdep-cancel.h (CENABLE): Save
	the return value to a safe register.
	(CDISABLE): Set the function argument correctly.

diff -u3prN ORIG/libc/nptl/sysdeps/unix/sysv/linux/sh/sysdep-cancel.h LOCAL/libc/nptl/sysdeps/unix/sysv/linux/sh/sysdep-cancel.h
--- ORIG/libc/nptl/sysdeps/unix/sysv/linux/sh/sysdep-cancel.h	Thu Mar 18 11:07:46 2004
+++ LOCAL/libc/nptl/sysdeps/unix/sysv/linux/sh/sysdep-cancel.h	Sat Mar 20 10:29:28 2004
@@ -207,7 +207,7 @@
 	bsrf r0; \
 	 nop; \
      0: bra 2f; \
-	 nop; \
+	 mov r0,r2; \
 	.align 2; \
      1: .long __local_enable_asynccancel - 0b; \
      2:
@@ -215,7 +215,7 @@
 # define CDISABLE \
 	mov.l 1f,r0; \
 	bsrf r0; \
-	 nop; \
+	 mov r2,r4; \
      0: bra 2f; \
 	 nop; \
 	.align 2; \


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]