This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Change INTERNAL_SYSCALL* so that it supports both arches which have error embedded in retval and arches which signal error otherwise

From: Roland McGrath <roland at redhat dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: Ulrich Drepper <drepper at redhat dot com>,Richard Henderson <rth at redhat dot com>,Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: Sun, 5 Jan 2003 17:19:41 -0800
Subject: Re: [PATCH] Change INTERNAL_SYSCALL* so that it supports both arches which have error embedded in retval and arches which signal error otherwise

> The usage is like:
> INTERNAL_SYSCALL_DECL (err);
> retval = INTERNAL_SYSCALL (syscall_name, err, 3, arg1, arg2, arg3);
> if (INTERNAL_SYSCALL_ERROR_P (retval, err))
>   errno_from_syscall = INTERNAL_SYSCALL_ERRNO (retval, err);

I guess this is ok, but a little bulky.  If it's always `int err' and
nonzero to indicate, on x86 that's something like "err = retval < 0 ?
-retval : 0;".  Does the compiler really fail to eliminate all that work if
`err' is dead?

Follow-Ups:
- Re: [PATCH] Change INTERNAL_SYSCALL* so that it supports both archeswhich have error embedded in retval and arches which signal error otherwise
  - From: Ulrich Drepper

References:
- [PATCH] Change INTERNAL_SYSCALL* so that it supports both arches which have error embedded in retval and arches which signal error otherwise
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]